Download candidate builds from candidates/ and not nightly/ #221
Conversation
|
@jayrajput thanks for your patch! Can I ask you to split this PR into two different ones? Each PR should only fix a given issue, but should not cover multiple ones. |
| @@ -0,0 +1,2 @@ | |||
| 20131001030204 | |||
| http://hg.mozilla.org/comm-central/rev/6b92cb377496 | |||
There was a problem hiding this comment.
Not sure if you have used git mv for all those changes. If not please reconsider that when you re-create the patch. If you don't do this we will loose all the version history.
There was a problem hiding this comment.
I have removed #22 from the repository. So now the repository has changes only for #218. I am sending a pull request.
I did not got your comment for "git mv". These are new files added to the repository and not moved. I did copied them from the nightly using unix "cp -R" command and then using git add followed by git commit. What is that you want me to change in respect to #218.
There was a problem hiding this comment.
As you can see in my last comment, you cannot copy them all. We only need the candidate builds, but not all the nightly builds.
There was a problem hiding this comment.
So when you move the files from nightly/ to candidate/, you should use git mv instead of the plain mv command. See http://githowto.com/moving_files
whimboo
changed the title
| @@ -13,111 +13,111 @@ | |||
| import mozhttpd_base_test as mhttpd | |||
|
|
|||
| firefox_tests = [ | |||
| # -p win32 -v 21.0 | |||
| # -p win32 -v 28.0 | |||
There was a problem hiding this comment.
In terms of our tests, we have those to verify that download will succeed. We are aware of that test data will not always be up-to-date. Means we don't want to update the version numbers each time we test those files. It doesn't matter for us, if it is Firefox 10.0, 21.0, or 28.0. Important is that we download the correct version. Only in case that the structure on the FTP server is changing, we will have to make sure to update those versions. So please only move the test files to the new location, and update the target_url in terms of the nightly -> candidates change.
|
Thanks Jay for the update. This looks lovely now. Would you mind to rebase all the commits into a single one? Once done I can land your PR. |
|
I have rebased all the commits as suggested. The changes can be merged now. Let me know if you have any more comments. |
|
I fixed the commit message to align with our specs, and merged the PR as d4eba84. |
Updated nightly with candidates in scrapper.py (ReleaseCandidateScrapper::candidate_build_list_regex). Updates to tests.